Skip to content

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Jul 23, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1210856879005136?focus=true

Description

Fixes actionlint warnings
- android-large-runner is a valid runner
- Fix useless cat warning
- Fix potential globbing of $Flank

Steps to test this PR

  • No action lint warnings on this PR
  • Check command behaviours match previous

UI changes

N/A

"shellcheck reported issue in this script: SC2002:style:1:5: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead [shellcheck]"
"shellcheck reported issue in this script: SC2086:info:1:6: Double quote to prevent globbing and word splitting [shellcheck]"
@mikescamell mikescamell requested a review from Copilot July 23, 2025 10:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses actionlint warnings in the GitHub Actions workflows by implementing configuration changes and shell command improvements to eliminate linting issues.

Key changes:

  • Adds actionlint configuration to suppress false warnings about the android-large-runner
  • Fixes shell command issues by properly quoting variables and replacing inefficient cat usage
  • Configures the workflow validation to use the new actionlint configuration file

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/validate_workflows.yml Adds actionlint configuration file flag to workflow validation
.github/actionlint.yaml Creates new actionlint configuration to whitelist the android-large-runner
.github/workflows/privacy.yml Fixes variable quoting and replaces cat with input redirection
.github/workflows/nightly.yml Fixes variable quoting and replaces cat with input redirection
.github/workflows/external-ref-tests.yml Fixes variable quoting and replaces cat with input redirection
.github/workflows/external-css-tests.yml Fixes variable quoting and replaces cat with input redirection
.github/workflows/ci.yml Fixes variable quoting and replaces cat with input redirection

@mikescamell mikescamell marked this pull request as ready for review July 23, 2025 10:42
@mikescamell mikescamell assigned karlenDimla and unassigned malmstein Aug 22, 2025
@mikescamell mikescamell merged commit 8f04621 into develop Aug 22, 2025
11 checks passed
@mikescamell mikescamell deleted the feature/mike/fix-actionlint-warnings branch August 22, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants